Add cautionary advice about SQL reserved words #9541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msheakoski thanks for adding this useful note to docs. We merged it on 2.7 branch and it will later be automatically merged up to all the other branches. Congrats on your first Symfony Docs contribution too! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 3, 2018
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #9541). Discussion ---------- Add cautionary advice about SQL reserved words I ran into this issue while following the security docs to set up authentication from the database and thought that it would be a helpful tip for future readers. Commits ------- 52af828 Add cautionary advice about SQL reserved words
wouterj
pushed a commit
that referenced
this pull request
May 5, 2018
Naming the table “user” without backtick quoting will trigger an error for anybody that copy/pastes the code because “USER” is a SQL reserved word. See #9541 for more details.
wouterj
added a commit
that referenced
this pull request
May 5, 2018
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #9551). Discussion ---------- Quote “user” table in example code with backticks Naming the table “user” without backtick quoting will trigger an error for anybody that copy/pastes the code because “USER” is a SQL reserved word. See #9541 for more details. Commits ------- 27efc38 Quote “user” table in example code with backticks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue while following the security docs to set up authentication from the database and thought that it would be a helpful tip for future readers.