Skip to content

[Contributing] Avoid the use of controversial language #9529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

codedmonkey
Copy link
Contributor

This PR removes the usage of any controversial and politically charged wording from the guidelines for review comments. This PR is not meant to diminish any problem anybody is having, rather to enforce the idea that addressing any person in any undesirable way is a no-go.

@codedmonkey codedmonkey changed the base branch from master to 3.4 March 31, 2018 15:24
@javiereguiluz
Copy link
Member

@codedmonkey thanks for this contribution! I'm pinging some people that frequently engage in discussions about diversity so they can give their opinion about this: @egircys, @lsmith77, @ElectricMaxxx, @sstok.

Of course the entire community is also invited to discuss about this, no matter if they are in favor or against this change. The only condition is to not discuss about politics. We never discuss about politics in Symfony code and doc repos. Thanks!

@lsmith77
Copy link
Contributor

lsmith77 commented Apr 1, 2018

look fine to me.

Copy link
Member

@egircys egircys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @codedmonkey! :)

While not "formally" required, it's better to use gender-neutral pronouns.
Unless someone "indicated" their pronouns, use "they", "them" instead of
"he", "she", "his", "hers", "his/hers", "he/she", etc.
In an effort to be inclusive to a wide group of developers, it's recommended to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to use people instead of developers?

words like "folks", "team", "everyone" in place of "guys".
Try to avoid using wording that may be considered excluding, needlessly gendered
(e.g. words that have a male or female base), racially motivated or singles out
a particular group in society. For example, we recommend to use words like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep the same form, like in the previous block, it's recommended instead of we recommend?

Copy link
Member

@javiereguiluz javiereguiluz Apr 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agree. In the Symfony Docs we never use "we". It was a decision taken a few years ago, so we prefer to keep it. Thanks!

@javiereguiluz javiereguiluz added the diversity & inclusion Related to Symfony Diversity Initiative https://github.com/symfony/diversity label Apr 1, 2018
@sstok
Copy link
Contributor

sstok commented Apr 2, 2018

Great addition 👍

@javiereguiluz javiereguiluz added this to the 2.7 milestone Apr 3, 2018
@javiereguiluz javiereguiluz changed the base branch from 3.4 to 2.7 April 3, 2018 08:57
@javiereguiluz javiereguiluz force-pushed the fix_controversial_language branch from ae843d9 to 60aec5f Compare April 3, 2018 08:57
@javiereguiluz
Copy link
Member

Thanks ... and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit 60aec5f into symfony:2.7 Apr 3, 2018
javiereguiluz added a commit that referenced this pull request Apr 3, 2018
…odedmonkey)

This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes #9529).

Discussion
----------

[Contributing] Avoid the use of controversial language

This PR removes the usage of any controversial and politically charged wording from the guidelines for review comments. This PR is not meant to diminish any problem anybody is having, rather to enforce the idea that addressing any person in any undesirable way is a no-go.

Commits
-------

60aec5f Rewrite the gender-neutral pronoun section to reflect an inclusive viewpoint for everyone
@codedmonkey
Copy link
Contributor Author

Thanks for the positive responses :) Great additions to the docs!

@codedmonkey codedmonkey deleted the fix_controversial_language branch April 4, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diversity & inclusion Related to Symfony Diversity Initiative https://github.com/symfony/diversity Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants