[Encore] Don't enable the Sass loader at the beginning of the First Example page #9526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
force-pushed
the
warn-missing-sass-dependencies
branch
from
24bd2de to
c0cfd35
Compare
|
I also think the report is legit @Lyrkan. But, what about commenting out all of the features that require extra packages so that the first build is successful? Then we can show an example of uncommenting the |
Lyrkan
force-pushed
the
warn-missing-sass-dependencies
branch
from
c0cfd35 to
b071ed2
Compare
Lyrkan
changed the title
|
@weaverryan I agree, should be better now :) |
javiereguiluz
added
Status: Reviewed
Webpack Encore
and removed
Status: Needs Review
labels
javiereguiluz
force-pushed
the
warn-missing-sass-dependencies
branch
from
b071ed2 to
18586e2
Compare
|
@Lyrkan this was a great first contribution to Symfony Docs! Thanks a lot. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 16, 2018
… the First Example page (Lyrkan) This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes #9526). Discussion ---------- [Encore] Don't enable the Sass loader at the beginning of the First Example page Someone pointed out in symfony/webpack-encore#287 that if you follow the [First example](http://symfony.com/doc/master/frontend/encore/simple-example.html) page from top to bottom you are going to run `yarn encore` before being informed that calling `enableSassLoader()` implies adding additional dependencies (which is done just after). ~~This PR moves the related paragraph to warn the user that Encore will tell him about missing packages before he encounters the error.~~ ~~I also added the "after running it" part to make it a bit more obvious that the information is going to be present in the command output.~~ **Edit:** Changed it so `enableSassLoader()` is commented before running Encore for the first time Commits ------- 18586e2 [Encore] Don't enable the Sass loader at the beginning of the First Example page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone pointed out in symfony/webpack-encore#287 that if you follow the First example page from top to bottom you are going to run
yarn encorebefore being informed that callingenableSassLoader()implies adding additional dependencies (which is done just after).This PR moves the related paragraph to warn the user that Encore will tell him about missing packages before he encounters the error.I also added the "after running it" part to make it a bit more obvious that the information is going to be present in the command output.Edit: Changed it so
enableSassLoader()is commented before running Encore for the first time