Missing namespace #9522
Merged
Missing namespace #9522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
reviewed
Mar 29, 2018
| @@ -177,6 +177,8 @@ rich API for a ``product`` table? Create a ``Product`` entity and give it the | |||
|
|
|||
| // src/Entity/Product.php | |||
| // ... | |||
There was a problem hiding this comment.
This expression makes explicit that there are some statements which are not exposed at this point in the file.
There was a problem hiding this comment.
Although you are right, this is the "Quick Tour" docs, so it's designed for the absolute Symfony newcomer. I think it's better if we show all use and all namesapces in the examples of this section. Let's merge this and I'll review the other examples in a separate PR.
|
@LordPachelbel thanks for taking care of this. It's a nice fix and shows great attention to detail. Congrats also on your first Symfony Docs contribution. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 30, 2018
This PR was merged into the 4.0 branch. Discussion ---------- Missing namespace This tripped me up when I was going through this tutorial until I figured out what the namespace was supposed to be. Commits ------- 46252b7 The namespace was missing
javiereguiluz
added a commit
that referenced
this pull request
Apr 3, 2018
…amespaces", etc.) (javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- Made all examples of "Quick Tour" complete (all "use", "namespaces", etc.) After #9522 I thought we could make all "Quick Tour" examples complete. This is worse for expert developers ... but I think it's better for newcomers, which are the readers of these articles. Commits ------- 7ab953c Made all examples of "Quick Tour" complete (all "use", "namespaces", etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tripped me up when I was going through this tutorial until I figured out what the namespace was supposed to be.