Skip to content

Document Updated make:entity command #9487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Document Updated make:entity command #9487

merged 1 commit into from
Apr 18, 2018

Conversation

weaverryan
Copy link
Member

@weaverryan weaverryan commented Mar 23, 2018

Hi guys!

The make:entity command in MakerBundle 1.3 is quite a bit more powerful - it interactively asks for fields (like doctrine:generate:entity), but also updating existing entities, supports relationships and generates adders/removers that synchronize the owning side of a relationship.

I've still included what the generated code looks like, because I want users to know the command is optional, and also to see what the code looks like when they're reading.

Cheers!

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice. I know this command is controversial for some people ... but it will definitely help lots of our readers. Thanks!

doctrine.rst Outdated
.. _doctrine-adding-mapping:

You can use the ``make:entity`` command to create this class and any fields you
need. The command will ask you some questions - answer them like we've done below:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never use "we" in the docs, so what about: like we've done below -> like done below ?

@javiereguiluz
Copy link
Member

Can we please rebase this to merge it? Thanks!

@weaverryan
Copy link
Member Author

Fixed! Not with a rebase though... im on my phone... :)

@weaverryan weaverryan merged commit 5569400 into symfony:4.0 Apr 18, 2018
weaverryan added a commit that referenced this pull request Apr 18, 2018
This PR was squashed before being merged into the 4.0 branch (closes #9487).

Discussion
----------

Document Updated make:entity command

Hi guys!

The make:entity command in MakerBundle 1.3 is quite a bit more powerful - it interactively asks for fields (like `doctrine:generate:entity`), but also updating existing entities, supports relationships and generates adders/removers that synchronize the owning side of a relationship.

I've still included what the generated code looks like, because I want users to know the command is optional, and also to see what the code looks like when they're reading.

Cheers!

Commits
-------

5569400 Document Updated make:entity command
@weaverryan weaverryan deleted the add-make-entity-command branch April 18, 2018 14:02
@xabbuh
Copy link
Member

xabbuh commented Apr 19, 2018

@weaverryan Something looks really strange here. Why does the PR contain so many changed files?

@xabbuh xabbuh added this to the 4.0 milestone Apr 19, 2018
@alexislefebvre
Copy link
Contributor

@xabbuh The merge commit only contains the related changes so it looks good: 53b231b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants