Added a note for the test-pack #9452
Conversation
|
symfony/recipes#382 has been merged now. |
HeahDude
force-pushed
the
fix-testing-4.0
branch
from
e29a690 to
3eac413
Compare
testing.rst
Outdated
| @@ -20,7 +20,7 @@ wraps the original PHPUnit binary to provide additional features: | |||
|
|
|||
| .. code-block:: terminal | |||
|
|
|||
| $ composer require --dev symfony/phpunit-bridge | |||
| $ composer require --dev phpunit | |||
There was a problem hiding this comment.
Not sure about this change. The phpunit thing is an alias to our phpunit-bridge... but if we use just phpunit, then the reader doesn't know if they are installing PHPUnit or "our PHPUnit". Also, I'm not sure about removing the ./vendor/bin/simple-phpunit commands. What's the reasoning behind that?
There was a problem hiding this comment.
Thank you for you review, but I don't understand what you mean exactly by
if we use just phpunit, then the reader doesn't know if they are installing PHPUnit or "our PHPUnit"
are you talking of other contexts? Because here, we're saying that we need the bridge before showing the sample.
about removing the ./vendor/bin/simple-phpunit commands
This is how it works with Flex now. We just need to run ./bin/phpunit which is the bridge wrapper installed by the recipe, and is responsible for actually installing the phpunit's dependencies (ref https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/3.3/bin/phpunit, and symfony/recipes#277).
There was a problem hiding this comment.
We could add a note, maybe even a link, to say we use recipes here.
There was a problem hiding this comment.
Though I think I agree with Javier about not using the phpunit alias here
There was a problem hiding this comment.
Ok changed in 9a6b058.
Is this ok for you? Should I remove the new note?
testing.rst
Outdated
| @@ -260,6 +265,17 @@ document:: | |||
| $client->getResponse()->getContent() | |||
| ); | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
Let's make this a tip instead, shouldn't we?
There was a problem hiding this comment.
Why not? @javiereguiluz wdyt?
There was a problem hiding this comment.
I finally could review this! Thanks for these changes. I did some minor rewords after the changes we made in #9742 regarding the use of Flex shortcuts.
|
Thanks ... and I'm sorry it took so long to merge this! |
This PR was merged into the 4.0 branch. Discussion ---------- Added a note for the test-pack <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 8b48e9b Rewords and simplifications 9a6b058 fixup phpunit require 3eac413 Added a note for the test-pack
No description provided.