Server version should be specified as a string #9445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the server version is specified without quotes like this:
```yml
server_version: 5.6
```
The resulting compiled container will contain the value
```php
->createConnection(
...
'serverVersion' => 5.5999999999999996447286321199499070644378662109375,
...
)
```
This is a result of floating-point representation issues. Quoting the value will avoid that and will deliver the string `'5.6'` to the `version_compare` function, as it's expecting.
javiereguiluz
approved these changes
Mar 18, 2018
There was a problem hiding this comment.
@kalifg this is a very nice improvement ... and a great first contribution to Symfony Docs. I reworded it a bit to make the explanation more concise, but your original description was great. Thanks!
javiereguiluz
added a commit
that referenced
this pull request
Mar 18, 2018
…aviereguiluz)
This PR was merged into the 2.7 branch.
Discussion
----------
Server version should be specified as a string
If the server version is specified without quotes like this:
```yml
server_version: 5.6
```
The resulting compiled container will contain the value
```php
->createConnection(
...
'serverVersion' => 5.5999999999999996447286321199499070644378662109375,
...
)
```
This is a result of floating-point representation issues. Quoting the value will avoid that and will deliver the string `'5.6'` to the `version_compare` function, as it's expecting.
<!--
If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).
If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).
-->
Commits
-------
f525f75 Minor reword
8e50933 Server version should be specified as a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server version is specified without quotes like this:
The resulting compiled container will contain the value
->createConnection( ... 'serverVersion' => 5.5999999999999996447286321199499070644378662109375, ... )This is a result of floating-point representation issues. Quoting the value will avoid that and will deliver the string
'5.6'to theversion_comparefunction, as it's expecting.