Fix French translation #9438
Fix French translation #9438
Conversation
|
I'm native, I can tell it's not a counter-sens but saying "I like Symfony" = "Symfony is great" in the i18n example seems not very relevant to me. Not the same subject, opinion vs. assertion. If I was asked to translate "Symfony is great" in French with no context precision, I would certainly not take the risk to use the subject |
|
Thanks ... and congrats on your first contribution to this repository! Merci beaucoup |
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9438). Discussion ---------- Fix French translation In French, the `!` must have one space before and after, the english punctuation here use in French sentence is wrong. And "J'aime Symfony" is "I like Symfony", it has a different sense from "Symfony is great". Commits ------- e997a74 Fix French translation
|
Why is this closed rather than merged? If you need me to send the PR on an other branch you should have told me. |
|
@kylekatarnls let me explain how Symfony merging works. We use (both in code, docs and any other repo) a private tool to merge things (we don't use GitHub utilities to merge things). Our own tool creates a merge commit with the name of the person who merged ... but it also leaves the original commit of the original author. For example, I did this in Symfony code repo: symfony/symfony@15fe686 and Fabien merged it with this: symfony/symfony@009b4d2. In your case, you can see in 2.7 branch changelog your own commit and "my commit" (not mine, but generated on my name with the tool we use): https://github.com/symfony/symfony-docs/commits/2.7 I hope you better understand now how Symfony merges things. Thanks! |
|
Perfect! Thanks for explanation! |
In French, the
!must have one space before and after, the english punctuation here use in French sentence is wrong. And "J'aime Symfony" is "I like Symfony", it has a different sense from "Symfony is great".