Ask users to create two commits for reproducers #9416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Mar 10, 2018
contributing/code/reproducer.rst
Outdated
| @@ -44,7 +44,9 @@ edition. To do so: | |||
| ``reproduce_23657``, etc.) | |||
| #. Now you must add the minimum amount of code to reproduce the bug. This is the | |||
| trickiest part and it's explained a bit more later. | |||
| #. Add, commit and push all your changes. | |||
| #. Add, commit and push all your changes. If possible, make one commit for the | |||
There was a problem hiding this comment.
What about doing this in order, so people won't have to patch add stuff:
#. Go to https://github.com/symfony/symfony-standard and click on the **Fork**
button to make a fork of that repository or go to your already forked copy.
#. Clone the forked repository into your computer:
``git clone git://github.com/YOUR-GITHUB-USERNAME/symfony-standard.git``
#. Browse the project and create a new branch (e.g. ``issue_23567``,
``reproduce_23657``, etc.)
#. Add and commit the changes generated by Symfony.
#. Now you must add the minimum amount of code to reproduce the bug. This is the
trickiest part and it's explained a bit more later.
#. Add, commit and push your own changes.
|
@wouterj I did as you suggested. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9365 proposed by @ro0n.