Update upload_file.rst #9404
Merged
Update upload_file.rst #9404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$targetDirectory in service class, but $targetDir in services.yaml. Hm...
|
@TheSidSpears very nice catch! We recently changed the name of lots of variables ... and some issues were introduced when merging changes in the upper branches. Thanks for fixing it and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Mar 7, 2018
This PR was merged into the 4.0 branch. Discussion ---------- Update upload_file.rst $targetDirectory in service class, but $targetDir in services.yaml. Hm... Commits ------- c397ce7 Update upload_file.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$targetDirectory in service class, but $targetDir in services.yaml. Hm...