SF 4+ does not rely on Command inheritance anymore #9403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link is broken, please wait while I fix it... |
As stated in [UPGRADE FROM 3.x to 4.0](https://github.com/symfony/symfony/blob/master/UPGRADE-4.0.md#httpkernel), relying on convention-based commands discovery is not supported anymore. This trick will only work with bundle autoconfiguration, which is not enabled by default on many 3rd-party bundles. This means a 3rd party bundle that wants to upgrade from SF 3.4 to SF 4.0 doesn't just have to edit its `composer.json`, its commands must either be tagged with `console.command` or autoconfigured. When [struggling with this](https://stackoverflow.com/questions/49134340/symfony-4-3rd-party-bundle-commands-are-no-longer-automatically-discovered) my eyes just hit the _Symfony registers any PHP class extending Command as a console command automatically_ sentence and I didn't figure out why it didn't work.
|
@bpolaszek this is a really important fix because wrong docs are worse than no docs. Thanks for contributing this and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Mar 7, 2018
…szek) This PR was merged into the 4.0 branch. Discussion ---------- SF 4+ does not rely on Command inheritance anymore As stated in [UPGRADE FROM 3.x to 4.0](https://github.com/symfony/symfony/blob/master/UPGRADE-4.0.md#httpkernel), relying on convention-based commands discovery is not supported anymore. This trick will only work with bundle autoconfiguration, which is not enabled by default on many 3rd-party bundles. This means a 3rd party bundle that wants to upgrade from SF 3.4 to SF 4.0 doesn't just have to edit its `composer.json`, its commands must either be tagged with `console.command` or autoconfigured. When [struggling with this](https://stackoverflow.com/questions/49134340/symfony-4-3rd-party-bundle-commands-are-no-longer-automatically-discovered) my eyes just hit the _Symfony registers any PHP class extending Command as a console command automatically_ sentence and I didn't figure out why it didn't work. Commits ------- f8fef4a SF 4+ does not rely on Command inheritance anymore
|
Thank you @javiereguiluz 👍 |
javiereguiluz
added a commit
that referenced
this pull request
Mar 9, 2018
…guiluz) This PR was squashed before being merged into the 2.7 branch (closes #9408). Discussion ---------- Added a short section about registering commands After merging #9403, I realized that we could add a short section explaining that commands must be registered (although Symfony does this for you most of the times). If we merge this, in 3.4 I'll change the description to mention the autoconfiguration instead of this, which is what #9403 fixed. Commits ------- 2efefea Added a short section about registering commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in UPGRADE FROM 3.x to 4.0, relying on convention-based commands discovery is not supported anymore.
This trick will only work with bundle autoconfiguration, which is not enabled by default on many 3rd-party bundles. This means a 3rd party bundle that wants to upgrade from SF 3.4 to SF 4.0 doesn't just have to edit its
composer.json, its commands must either be tagged withconsole.commandor autoconfigured.When struggling with this my eyes just hit the Symfony registers any PHP class extending Command as a console command automatically sentence and I didn't figure out why it didn't work.