Clarify unanimous access strategy description #9363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Steveb-p this is a great improvement of a critical information that was misleading! I've reworded it a bit reusing parts of the Symfony code comments ... and I also merged it on 2.7 branch, which is the oldest maintained branch where this change is applicable (here you can find all maintained branches: https://symfony.com/roadmap). That's why GitHub looks it as closed instead of merged, but it's merged. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Mar 1, 2018
…javiereguiluz) This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9363). Discussion ---------- Clarify unanimous access strategy description In my opinion saying that unanimous strategy "requires all voters to grant access" is misleading. In actuality, this strategy requires that no voter denies access, and this PR intends to clarify that. Commits ------- b4c2e90 Minor reword 94d6f30 Clarify unanimous access strategy description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion saying that unanimous strategy "requires all voters to grant access" is misleading. In actuality, this strategy requires that no voter denies access, and this PR intends to clarify that.