Skip to content

Update access_control.rst #9344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update access_control.rst #9344

wants to merge 2 commits into from

Conversation

kockodev
Copy link
Contributor

@kockodev kockodev commented Feb 26, 2018

Extend documentation with IP netmask

Extend documentation with IP range
Fix IP range to IP netmask
@javiereguiluz
Copy link
Member

@rapemer just asking. Do this work in Symfony 2.7 too? If yes, then we'll merge this on 2.7 branch. Thanks.

@kockodev
Copy link
Contributor Author

kockodev commented Feb 26, 2018

@javiereguiluz since this commit symfony/symfony@d9ac571#diff-23b6cd28961e2f301e71e2632ba728ab is available in IpUtils ... Since this PR symfony/symfony#7249 is documentation fully supported. I think branch 2.7 is fully supported.

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 26, 2018

Thanks! So, it's available since Symfony 2.3 and we'll then merge it on 2.7 branch. But there's no need for you to rebase this. We'll do that when merging. Thanks!

@javiereguiluz
Copy link
Member

@rapemer this was a very nice first contribution to Symfony Docs. Thank you!

javiereguiluz added a commit that referenced this pull request Feb 28, 2018
This PR was squashed before being merged into the 2.8 branch (closes #9344).

Discussion
----------

Update access_control.rst

Extend documentation with IP netmask

Commits
-------

c79ecf0 Update access_control.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants