Update service_container.rst #9337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 6 use `$message = (new \Swift_Message('message'))` instead of `$message = \Swift_Message::newInstance()`
Please check https://github.com/swiftmailer/swiftmailer/blob/master/CHANGES#L24 and https://swiftmailer.symfony.com/docs/introduction.html#basic-usage
|
@ilmoralito thanks for helping us improve Symfony Docs and congrts on your first contribution! I've tweaked your code a bit because the argument of \Swift_Message is the subject of the email, not its body. Also, we've merged this on 3.4, the oldest maintained branch that contains the error. That's why GitHub shows it as closed instead of merged, but it's merged. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 26, 2018
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9337). Discussion ---------- Update service_container.rst Since 6 use `$message = (new \Swift_Message('message'))` instead of `$message = \Swift_Message::newInstance()` Please check https://github.com/swiftmailer/swiftmailer/blob/master/CHANGES#L24 and https://swiftmailer.symfony.com/docs/introduction.html#basic-usage Commits ------- e4ba061 Fixed the code 17da22a Update service_container.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 6 use
$message = (new \Swift_Message('message'))instead of$message = \Swift_Message::newInstance()Please check https://github.com/swiftmailer/swiftmailer/blob/master/CHANGES#L24 and https://swiftmailer.symfony.com/docs/introduction.html#basic-usage