Skip to content

Fix static method call #9334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Fix static method call #9334

merged 1 commit into from
Feb 25, 2018

Conversation

patrik-csak
Copy link
Contributor

Changed occurrences of $progressBar->setFormatDefinition(/*…*/) to ProgressBar::setFormatDefinition(/*…*/)

@javiereguiluz
Copy link
Member

@ptrkcsk thanks! It's true that setFormatDefinition() method is static. See https://github.com/symfony/symfony/blob/cd5f4105a43208632c8b62fd75b4dad53dcd8a41/src/Symfony/Component/Console/Helper/ProgressBar.php#L115 but don't you think that the code now is a bit ugly? But I guess we can't do any better 😞

@patrik-csak
Copy link
Contributor Author

@javiereguiluz It's consistent with the examples in the Custom Formats section of the same page.

@javiereguiluz
Copy link
Member

You are completely right! Sorry for not having checked this. Merging it. Thanks and congrats on your first contribution to Symfony Docs!

@javiereguiluz javiereguiluz merged commit e9c7a2e into symfony:2.7 Feb 25, 2018
javiereguiluz added a commit that referenced this pull request Feb 25, 2018
This PR was merged into the 2.7 branch.

Discussion
----------

Fix static method call

Changed occurrences of `$progressBar->setFormatDefinition(/*…*/)` to `ProgressBar::setFormatDefinition(/*…*/)`

Commits
-------

e9c7a2e Fix static method call
@patrik-csak
Copy link
Contributor Author

@javiereguiluz No problem. Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants