Skip to content

Update dbal.rst #9322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update dbal.rst #9322

wants to merge 2 commits into from

Conversation

stormoPL
Copy link
Contributor

Current documentation steps do not work for fresh Symfony 4 instance. Doctrine.yml file does not exist and DBAL installation from Composer does not get recognized or autowired. DoctrineBundle is a way to use both Doctrine ORM on the top of Doctrine DBAL or just pure DBAL.

Current documentation steps do not work for fresh Symfony 4 instance. Doctrine.yml file does not exist and DBAL installation from Composer does not get recognized or autowired. DoctrineBundle is a way to use both Doctrine ORM on the top of Doctrine DBAL or just pure DBAL.
@xabbuh xabbuh added this to the 4.0 milestone Feb 23, 2018
@@ -20,6 +20,8 @@ makes it easy to execute queries and perform other database actions.

Read the official Doctrine `DBAL Documentation`_ to learn all the details
and capabilities of Doctrine's DBAL library.

Before you start you will need `DoctrineBundle`_ which supports both Doctrine ORM and Doctrine DBAL (together or just DBAL). This will generate ``config/packages/doctrine.yaml``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to how we do that in other articles I would write something like this:

First, install the Doctrine bundle:

.. code-block:: terminal

    composer require doctrine/doctrine-bundle

Instruction style changed as per recommendation in pull request review to fit general documentation style.
@javiereguiluz
Copy link
Member

@stormoPL thanks for this improvement! You did great. And congrats on your first Symfony Docs contribution too!

javiereguiluz added a commit that referenced this pull request Feb 26, 2018
This PR was squashed before being merged into the 4.0 branch (closes #9322).

Discussion
----------

Update dbal.rst

Current documentation steps do not work for fresh Symfony 4 instance. Doctrine.yml file does not exist and DBAL installation from Composer does not get recognized or autowired. DoctrineBundle is a way to use both Doctrine ORM on the top of Doctrine DBAL or just pure DBAL.

Commits
-------

60d14ab Update dbal.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants