Updates to language on The Big Picture #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``_controller`` routing value: ``HelloBundle``). | ||
| * *line 3*: Symfony2 takes advantage of new PHP 5.3 namespacing features, and | ||
| all controllers should be properly namespaced. Per the routing file above, | ||
| the namespace is the first part of the ``_controller`` routing value: |
There was a problem hiding this comment.
This should be changed as the first part is the bundle name, not a namespace.
There was a problem hiding this comment.
You're right, I've made this change: 27e1812
|
Thanks for the careful work guys. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various language updates to improve readability for English users. Also simplified some concepts.