Skip to content

Mention that argon2i doesn't need a salt either #9269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions security/entity_provider.rst
Original file line number Diff line number Diff line change
Expand Up @@ -316,12 +316,12 @@ and password ``admin`` (which has been encoded).

.. sidebar:: Do you need to use a Salt property?

If you use ``bcrypt``, no. Otherwise, yes. All passwords must be hashed
with a salt, but ``bcrypt`` does this internally. Since this tutorial
*does* use ``bcrypt``, the ``getSalt()`` method in ``User`` can just
return ``null`` (it's not used). If you use a different algorithm, you'll
need to uncomment the ``salt`` lines in the ``User`` entity and add a
persisted ``salt`` property.
If you use ``bcrypt`` or ``argon2i``, no. Otherwise, yes. All passwords must
be hashed with a salt, but ``bcrypt`` and ``argon2i`` do this internally.
Since this tutorial *does* use ``bcrypt``, the ``getSalt()`` method in
``User`` can just return ``null`` (it's not used). If you use a different
algorithm, you'll need to uncomment the ``salt`` lines in the ``User``
entity and add a persisted ``salt`` property.

.. _security-advanced-user-interface:

Expand Down