Explaining the "one-to-many" case more explicitly #9259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please double-check: I'm not certain if "For a many-to-many relationship:" (line 574) is correct!
xabbuh
reviewed
Feb 23, 2018
form/form_collections.rst
Outdated
| ``false``:: | ||
| ``false``. | ||
|
|
||
| For a one-to-many relationship you just need to add one line to ``Task``: |
There was a problem hiding this comment.
This is misleading, in fact it's the opposite here (i.e. many-to-one). Maybe we should just manage this using inline comments like this:
public function addTag(Tag $tag)
{
// for a many-to-many association
$tag->addTask($this);
// for a many-to-one association
$tag->setTask($this);
$this->tags->add($tag);
}There was a problem hiding this comment.
Yeah, good idea, done that - see https://github.com/symfony/symfony-docs/pull/9259/files#diff-3dccfe528cd4fc9a1dd946f388e5956b
xabbuh
approved these changes
Feb 23, 2018
|
Thanks Thomas. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 24, 2018
…Landauer) This PR was squashed before being merged into the 2.7 branch (closes #9259). Discussion ---------- Explaining the "one-to-many" case more explicitly Please double-check: I'm not certain if "For a many-to-many relationship:" (line 574) is correct! Commits ------- 5636b52 Explaining the "one-to-many" case more explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please double-check: I'm not certain if "For a many-to-many relationship:" (line 574) is correct!