Skip to content

Added a note about the dangers of dumping $_SERVER and $_ENV #9245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2018
Merged

Added a note about the dangers of dumping $_SERVER and $_ENV #9245

merged 1 commit into from
Feb 13, 2018

Conversation

javiereguiluz
Copy link
Member

This fixes #9237.

@javiereguiluz javiereguiluz added this to the 4.0 milestone Feb 11, 2018
linaori
linaori approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this info will be very helpful for devs!

@javiereguiluz javiereguiluz merged commit d9aedee into symfony:4.0 Feb 13, 2018
javiereguiluz added a commit that referenced this pull request Feb 13, 2018
@javiereguiluz
minor #9245 Added a note about the dangers of dumping $_SERVER and $_…
f21ed5d 
…ENV (javiereguiluz)

This PR was merged into the 4.0 branch.

Discussion
----------

Added a note about the dangers of dumping $_SERVER and $_ENV

This fixes #9237.

Commits
-------

d9aedee Added a note about the dangers of dumping $_SERVER and $_ENV
@javiereguiluz javiereguiluz mentioned this pull request Feb 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

@linaori linaori linaori approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @acrobat @linaori @carsonbot