Skip to content

Fix references to annotation loader tip #9208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

maff
Copy link
Contributor

@maff maff commented Feb 5, 2018

Tips were refactored to an include file in 0ddf3d2 but referenced the wrong filename. a0b19c3 removed the wrong tip from the serializer page.

This fixes the tip references on routing/validator and restores the tip on the serializer, but with the right reference.

Tips were refactored to an include file in
0ddf3d2 but referenced the wrong
filename. a0b19c3 removed the wrong tip
from the serializer page.

This fixes the tip references on routing/validator and restores the tip
on the serializer, but with the right reference.
@javiereguiluz
Copy link
Member

@maff this was a very nice catch and solve multiple issues. Thanks a lot!

@javiereguiluz javiereguiluz merged commit 1f422cf into symfony:2.7 Feb 6, 2018
javiereguiluz added a commit that referenced this pull request Feb 6, 2018
This PR was merged into the 2.7 branch.

Discussion
----------

Fix references to annotation loader tip

Tips were refactored to an include file in 0ddf3d2 but referenced the wrong filename. a0b19c3 removed the wrong tip from the serializer page.

This fixes the tip references on routing/validator and restores the tip on the serializer, but with the right reference.

Commits
-------

1f422cf Fix references to annotation loader tip
@maff maff deleted the fix-annotation-tips branch February 6, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants