Skip to content

fix typo: continuting -> continuing #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix typo: continuting -> continuing #9192

wants to merge 1 commit into from

Conversation

brizzz
Copy link
Contributor

@brizzz brizzz commented Feb 2, 2018

No description provided.

@xabbuh xabbuh added this to the 3.4 milestone Feb 2, 2018
@javiereguiluz
Copy link
Member

@brizzz thanks! We merged it on 3.4 branch, that's why GitHub makes it look as closed instead of merged ... but it's merged.

javiereguiluz added a commit that referenced this pull request Feb 2, 2018
@javiereguiluz
minor #9192 fix typo: continuting -> continuing (brizzz)
925121c 
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9192).

Discussion
----------

fix typo: continuting -> continuing

Commits
-------

a584171 fix typo
@brizzz brizzz deleted the patch-1 branch February 2, 2018 12:49
@brizzz
Copy link
Contributor Author

brizzz commented Feb 2, 2018

Thanks for comment! Can you please explain in short why it was submitted just to 3.4 and not to 4.0?

@xabbuh
Copy link
Member

xabbuh commented Feb 2, 2018

3.4 is the oldest maintained branch that was affected by this typo. From there we will merge it up to master so that the fix will eventually be applied to all maintained versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@brizzz @javiereguiluz @xabbuh @carsonbot