Documented the PhpExecutableFinder utility #9182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas do you think it's worth it to document this utility or it's something mostly internal? Thanks! |
components/process.rst
Outdated
| This component also provides a utility class called | ||
| :class:`Symfony\\Component\\Process\\PhpExecutableFinder` which returns the | ||
| absolute path of the executable PHP binary available on your server. It looks | ||
| for the PHP executable using environment variables like ``PHP_BINARY``, |
There was a problem hiding this comment.
I would remove this sentence: it is inaccurate, and it's complex to explain accurately
let just describe what it does, not how
javiereguiluz
added a commit
that referenced
this pull request
Feb 5, 2018
This PR was squashed before being merged into the 2.7 branch (closes #9182). Discussion ---------- Documented the PhpExecutableFinder utility I was going to document #9003 ... but I think we should not explain that because it's an internal detail and the code can be changed/improved at any time and we cannot keep the docs in sync. However, we could document the PhpExecutableFinder utility if we decide is useful enough. Commits ------- cbd6e2b Documented the PhpExecutableFinder utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to document #9003 ... but I think we should not explain that because it's an internal detail and the code can be changed/improved at any time and we cannot keep the docs in sync. However, we could document the PhpExecutableFinder utility if we decide is useful enough.