Skip to content

uploading example: explaining the need for md5 #9179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

uploading example: explaining the need for md5 #9179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ef7c12
uploading example: explaining the need for md5
MacDada Jan 31, 2018
5f00f81
Reword a code comment
javiereguiluz Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions controller/upload_file.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@ Finally, you need to update the code of the controller that handles the form::
/** @var Symfony\Component\HttpFoundation\File\UploadedFile $file */
$file = $product->getBrochure();

// Generate a unique name for the file before saving it
$fileName = md5(uniqid()).'.'.$file->guessExtension();
$fileName = $this->generateUniqueFileName().'.'.$file->guessExtension();

// Move the file to the directory where brochures are stored
$file->move(
Expand All @@ -154,6 +153,16 @@ Finally, you need to update the code of the controller that handles the form::
'form' => $form->createView(),
));
}

/**
* @return string
*/
private function generateUniqueFileName()
{
// md5() reduces the similarity of the file names generated by
// uniqid(), which is based on timestamps
return md5(uniqid());
}
}

Now, create the ``brochures_directory`` parameter that was used in the
Expand Down