Update translation.rst #9119
Update translation.rst #9119
Conversation
`MessageSelector` doesn't implement `Symfony\Component\Translation\Formatter\MessageFormatterInterface` - the expected second parameter for `Translator::__construct`, which is generated if not provided anyway. removing the second parameter in the example seems like the best option imho.
|
|
||
| $translator = new Translator('fr_FR', new MessageSelector()); | ||
| $translator = new Translator('fr_FR'); |
There was a problem hiding this comment.
Maybe you can replace with :
new MessageFormatter();There was a problem hiding this comment.
mh, I strongly disagree. My main reason being:
Neither the old MessageSelector nor the MessageFormatter appear in any of the texts surrounding the example and thus don't provide any value at all for the reader.
If the MessageFormatter were to be added, it would be helpful to provide the reader with some reason, opportunity or otherwise that can be gained by doing so. Since the text is targeted at developers wanting to include the Translator component, and the common use case described in the following texts don't include a MessageFormatter at all, I don't see the merits of adding a parameter that is not referenced at all.
I would agree, that the article could be improved by discussing the formatter parameter in some way, but this is way beyond the scope of this commit (and I would argue, that this would be going in some extra section)
|
@jakumi nice catch! Indeed removing this wrong argument is the best solution in this case. We've merged it on 3.4 branch, because that's the oldest maintained branch that contains the error (in 2.7 is not strictly an error, but passing the argument is not needed required, so we can remove it). When merging things in different branches GitHub makes it look as closed instead of merged ... but it's merged. Thanks! |
This PR was submitted for the 4.0 branch but it was squashed and merged into the 2.7 branch instead (closes #9119). Discussion ---------- Update translation.rst `MessageSelector` doesn't implement `Symfony\Component\Translation\Formatter\MessageFormatterInterface` - the expected second parameter for `Translator::__construct`, which is generated if not provided anyway. removing the second parameter in the example seems like the best option imho. Commits ------- 33ac660 Update translation.rst
MessageSelectordoesn't implementSymfony\Component\Translation\Formatter\MessageFormatterInterface- the expected second parameter forTranslator::__construct, which is generated if not provided anyway. removing the second parameter in the example seems like the best option imho.