Remove out-of-context rewrite rule tip #9109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.. include:: /_includes/_rewrite_rule_tip.rst.inc` has absolutely nothing to do with the surrounding context. Having it here is confusing.
javiereguiluz
approved these changes
Jan 23, 2018
|
@BlueM nice catch! I've merged it in 2.7 branch, the oldest maintained branch that contains the bug, so GitHub may make it look closed instead of merged ... but it's merged. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 23, 2018
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9109). Discussion ---------- Remove out-of-context rewrite rule tip The `.. include:: /_includes/_rewrite_rule_tip.rst.inc` has absolutely nothing to do with the surrounding context. Having it here is confusing. Commits ------- a0b19c3 Remove out-of-context rewrite rule tip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.. include:: /_includes/_rewrite_rule_tip.rst.inchas absolutely nothing to do with the surrounding context. Having it here is confusing.