-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Change to comply with documentation standards #9088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some verbs didn't follow documentation standards written here (https://symfony.com/doc/current/contributing/documentation/standards.html#english-language-standards).
I'm not strongly against this change ... but I can't find where this is recommended in the link you shared. Besides, we use this style in hundreds of examples across the doc, so it'd be almost impossible to fix everything. Now a personal opinion: I like the current style because it's easier to understand for me:
|
As you said, both styles are used in the documentation. There are inconsistencies, especially here, but I am not sure it is worth changing all of them. In my opinion, the correct style depends on the communication between the documentation and the reader. If the documentation tells the reader what to do, |
OK, so we should fix this inconsistency. I propose to use everywhere Note: whatever the decision, we should make those changes in 2.7 branch (the oldest maintained branch) and then we'll merge fixes up to the other branches. Thanks! |
@@ -181,7 +181,7 @@ If you're serving HTML, you'll want to render a template. The ``render()`` | |||
method renders a template **and** puts that content into a ``Response`` | |||
object for you:: | |||
|
|||
// renders templates/lucky/number.html.twig | |||
// render templates/lucky/number.html.twig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the previous style. @javiereguiluz explained that quite well. This comment explains what the code below does, not what you as a developer should do.
This PR was merged into the 2.7 branch. Discussion ---------- Make code comments consistent This finishes #9088 by doing the opposite change: when the comment describes what the code does instead of what the user must do, use the format: `// returns a ...` instead of `// return a ...` Commits ------- a439f63 Make code comments consistent
Some verbs didn't follow documentation standards written here.