Fixed the default value for toolbar configuration #9064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'll merge this in 2.7 branch because that's the oldest maintained branch where the change is needed. See https://github.com/symfony/symfony/blob/3ed19dd040643485f568fafa1b100d086eb7701e/src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/Configuration.php#L39 |
|
@nicosomb it's merged on 2.7 branch! Thanks for this ... and congrats on your first Symfony Docs contribution. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 17, 2018
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9064). Discussion ---------- Fixed the default value for toolbar configuration Because the below full default configuration shows that `toolbar` is set to `false`, we need to add consistence here. Commits ------- 1b78c34 Fixed the default value for toolbar configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the below full default configuration shows that
toolbaris set tofalse, we need to add consistence here.