Skip to content

css-selector is an optional dependency of the browser-kit #8982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2018
Merged

css-selector is an optional dependency of the browser-kit #8982

merged 1 commit into from
Jan 5, 2018

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Jan 5, 2018

restructured the testing introduction to not end up with an error in the first functional test example

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. I left some minor comments. Thanks.

testing.rst Outdated
Click on a link by first selecting it with the crawler using either an XPath
expression or a CSS selector, then use the client to click on it. For example::
The crawler integrates with the ``symfony/css-selector`` component to give you the
power of CSS selectors to find content in a page. To install the css selector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing: css selector -> CSS selector

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

restructured the testing introduction to not end up with an error in the first functional test example
@javiereguiluz
Copy link
Member

Thanks David.

@javiereguiluz javiereguiluz merged commit 9072354 into symfony:4.0 Jan 5, 2018
javiereguiluz added a commit that referenced this pull request Jan 5, 2018
… (dbu)

This PR was merged into the 4.0 branch.

Discussion
----------

css-selector is an optional dependency of the browser-kit

restructured the testing introduction to not end up with an error in the first functional test example

Commits
-------

9072354 css-selector is an optional dependency of the browser-kit
@dbu dbu deleted the patch-3 branch October 18, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants