Skip to content

This doc doesn't apply to version 3.4 #8978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2018
Merged

This doc doesn't apply to version 3.4 #8978

merged 1 commit into from
Jan 5, 2018

Conversation

Romain
Copy link
Contributor

@Romain Romain commented Jan 4, 2018

This documentation doesn't seem to apply to version 3.4.
I tried to use it without any success. I think that we should display a disclaimer since v3.4 doesn't use the bundle concept anymore.

This documentation doesn't seem to apply to version 3.4.
I tried to use it without any success. I think that we should display  a disclaimer since v3.4 doesn't use the bundle concept anymore.
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in sync with the warning message we display in 4.0 (https://symfony.com/doc/current/bundles.html). It makes sense to do this. Thanks!

@javiereguiluz
Copy link
Member

@Romain thanks for this and congrats on your first contribution to Symfony Docs!

@javiereguiluz javiereguiluz merged commit 7ecbe69 into symfony:3.4 Jan 5, 2018
javiereguiluz added a commit that referenced this pull request Jan 5, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

This doc doesn't apply to version 3.4

This documentation doesn't seem to apply to version 3.4.
I tried to use it without any success. I think that we should display  a disclaimer since v3.4 doesn't use the bundle concept anymore.

Commits
-------

7ecbe69 This doc doesn't apply to version 3.4
@Romain Romain deleted the patch-1 branch January 5, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants