Update the DSN format in XML, it should be escaped #8977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So using the same setting gives ``` Could not load "/var/www/app/phpunit.xml.dist". EntityRef: expecting ';' ``` The DSN should be escaped before added in the XML file.
javiereguiluz
approved these changes
Jan 5, 2018
There was a problem hiding this comment.
@pouyana thanks for this fix. You are right. However, since this doc was written, Symfony has changed a bit the Doctrine config.
Now in the env var we only put the host, username and password --> https://github.com/symfony/recipes/blob/3cb189ae3473066e3cb4d405c19c5fdc051fecee/doctrine/doctrine-bundle/1.6/manifest.json#L13
And in the normal Doctrine config file we put the other values -> https://github.com/symfony/recipes/blob/3cb189ae3473066e3cb4d405c19c5fdc051fecee/doctrine/doctrine-bundle/1.6/config/packages/doctrine.yaml#L11-L13 because they don't change as often as the other config.
So, I've reworded a bit your changes. Thanks and congrats on your first Symfony Docs contribution!
javiereguiluz
added a commit
that referenced
this pull request
Jan 5, 2018
…na, javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- Update the DSN format in XML, it should be escaped So using the same setting gives ``` Could not load "/var/www/app/phpunit.xml.dist". EntityRef: expecting ';' ``` The DSN should be escaped before added in the XML file. Commits ------- a1486af Removed additional Doctrine config params cbffec3 Update the DSN format in XML, it should be escaped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So using the same setting gives
The DSN should be escaped before added in the XML file.