Skip to content

Fixed an example in the form testing article #8971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

Fixed an example in the form testing article #8971

merged 1 commit into from
Jan 4, 2018

Conversation

javiereguiluz
Copy link
Member

This fixes #8970.

@javiereguiluz javiereguiluz mentioned this pull request Jan 3, 2018
Closed
wouterj
wouterj approved these changes Jan 3, 2018
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For now, but let's create an issue to improve this article.

It's quite complex if you don't understand forms well and I think it's not a good example of writing tests (and btw, it's not a Unit test at all if written like this)

@javiereguiluz javiereguiluz mentioned this pull request Jan 4, 2018
Closed
@javiereguiluz javiereguiluz merged commit 36c183e into symfony:2.7 Jan 4, 2018
javiereguiluz added a commit that referenced this pull request Jan 4, 2018
@javiereguiluz
minor #8971 Fixed an example in the form testing article (javiereguiluz)
a3bb54c 
This PR was merged into the 2.7 branch.

Discussion
----------

Fixed an example in the form testing article

This fixes #8970.

Commits
-------

36c183e Fixed an example in the form testing article
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
bug Form Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @wouterj @carsonbot