Update doctrine.rst #8949
Merged
Update doctrine.rst #8949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two minor issues in code examples
xabbuh
reviewed
Jan 1, 2018
| @@ -654,6 +654,8 @@ In addition to the query builder, you can also query with `Doctrine Query Langua | |||
|
|
|||
| public function findAllGreaterThanPrice($price): array | |||
| { | |||
| $em = $this->getEntityManager(); | |||
|
|
|||
| $query = $em->createQuery( | |||
There was a problem hiding this comment.
I think we could just use $this->_em here instead.
There was a problem hiding this comment.
I'm not sure if this is a good idea, since $this->_em has never been introduced before. Without you mentioning it I wouldn't know it existed. The other code example in the same section doesn't use it as well.
There was a problem hiding this comment.
That's true! And in the example below, we use $conn = $this->getEntityManager()->getConnection();
There was a problem hiding this comment.
Let's merge this "as is" ... and later we can think of explaining $this->_em somewhere and using it in all examples.
javiereguiluz
approved these changes
Jan 2, 2018
|
Thanks Marcus. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 2, 2018
This PR was merged into the 4.0 branch. Discussion ---------- Update doctrine.rst Fixes two minor issues in code examples Commits ------- 4e10bdd Update doctrine.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two minor issues in code examples