Recommend to use PHPUnitBridge instead of PHPUnit #8883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Dec 22, 2017
weaverryan
requested changes
Dec 28, 2017
weaverryan
reviewed
Dec 28, 2017
setup/bundles.rst
Outdated
| @@ -69,7 +69,8 @@ PHPUnit test report: | |||
|
|
|||
| .. code-block:: terminal | |||
|
|
|||
| $ phpunit | |||
| # this command is available after running "composer require phpunit" | |||
| $ ./bin/phpunit | |||
There was a problem hiding this comment.
This is a third-party bundle, so I think we should use the full component name, not the alias, right?
There was a problem hiding this comment.
The alias is for the bridge. So that looks good to me.
|
Ready for the final review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8808.