Replaced class per id in service definition in XML #8874
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using only `class` results in `Top-level services must have "id" attribute, none found`. Whereas using `id` instead of `class` is understood, and it is coherent with the YAML and PHP versions of the same definition.
xabbuh
approved these changes
Dec 14, 2017
|
Thank you @nacmartin. |
xabbuh
added a commit
that referenced
this pull request
Dec 22, 2017
…rtin) This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #8874). Discussion ---------- Replaced class per id in service definition in XML Using only `class` results in `Top-level services must have "id" attribute, none found`. Whereas using `id` instead of `class` is understood, and it is coherent with the YAML and PHP versions of the same definition. Commits ------- 2e0e63e Replaced class per id in service definition in XML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using only
classresults inTop-level services must have "id" attribute, none found. Whereas usingidinstead ofclassis understood, and it is coherent with the YAML and PHP versions of the same definition.