remove "choices_as_values" mention #8832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"choices_as_values" is still mentioned in the "Create a custom form field type" doc but has been removed in 4.0.
xabbuh
reviewed
Dec 5, 2017
form/create_custom_field_type.rst
Outdated
| @@ -35,8 +35,7 @@ for form fields, which is ``<BundleName>\Form\Type``. Make sure the field extend | |||
| 'Standard Shipping' => 'standard', | |||
| 'Expedited Shipping' => 'expedited', | |||
| 'Priority Shipping' => 'priority', | |||
| ), | |||
| 'choices_as_values' => true, | |||
| ) | |||
There was a problem hiding this comment.
Can you add back the trailing comma here?
xabbuh
approved these changes
Dec 5, 2017
|
We could IMO merge this into the |
|
Yes, this might be a good idea. |
|
Thanks Jérémy! I merged into 4.0 - I didn't feel strongly either way. It has perhaps some historical value on 3.3 (to explain what this option is and why you might see it in your project). Anyways, good catch and thank you! |
weaverryan
added a commit
that referenced
this pull request
Dec 5, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8832). Discussion ---------- remove "choices_as_values" mention "choices_as_values" is still mentioned in the "Create a custom form field type" doc but has been removed in 4.0. Commits ------- 79109a8 add back the trailing comma 982baa5 remove "choices_as_values" mention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"choices_as_values" is still mentioned in the "Create a custom form field type" doc but has been removed in 4.0.