Remove an unneeded logging article #8770
Conversation
|
Build failure is unrelated to this PR. This has been fixed in #8772. |
|
This looks good. Can you also add an entry to the redirection map? |
There was a problem hiding this comment.
I like the idea, but I'm not sure about the proposal. This is a very unimportant option. It doesn't deserve an entire section in my opinion. What if we just add a very short mention to it in this reference: https://symfony.com/doc/current/reference/configuration/monolog.html ?
|
Yea, I agree. We just need to add |
|
I am unsure about the comments. They are long right now, and that is the incorrect way according to the feedback @weaverryan gave in #8770 (comment). See commit 4b3ed43 about the changes. I'd love to get better comment texts to include instead of these long lines cluttering the article since this is such a small change. |
reference/configuration/monolog.rst
Outdated
| datetime field of the log messages from | ||
| microsecond to second. Avoiding a call to the | ||
| microtime(true) function and the subsequent parsing. --> | ||
| <monolog:config use-microseconds="true"> |
There was a problem hiding this comment.
No need to put the comments in XML also. We typically just put the comments in YAML - it's the most visible and avoids duplication :)
reference/configuration/monolog.rst
Outdated
| # the precision in the datetime field of the log messages from | ||
| # microsecond to second. Avoiding a call to the microtime(true) | ||
| # function and the subsequent parsing. | ||
| use_microseconds: true |
There was a problem hiding this comment.
I agree! This is a little long :). How about:
Set to false to use seconds (instead of microseconds) in the logs (gives a small performance boost)
|
@javiereguiluz No problem. It is good that we all pay attention so that the quality of the documentation remains high. |
|
Great improvement! Thank you Ricardo! |
ghost
deleted the
This is related to #8684. Sorry for the spelling error in the commit, didn't had my coffee yet ;)