Rewriting logic for accessing services from the console #8714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Nov 21, 2017
yceruto
reviewed
Nov 21, 2017
console.rst
Outdated
|
|
||
| // ... | ||
| use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand; | ||
| use AppBundle\Service\UserManager; | ||
|
|
||
| class CreateUserCommand extends ContainerAwareCommand |
There was a problem hiding this comment.
of course! Good catch
weaverryan
added a commit
that referenced
this pull request
Nov 24, 2017
…weaverryan) This PR was squashed before being merged into the 3.4 branch (closes #8714). Discussion ---------- Rewriting logic for accessing services from the console Fixes #8713 This is against 3.4, because it is the first time that your commands will be registered as services in practice. Commits ------- 4f656f2 fixing bad class 2def992 Rewriting logic for accessing services from the console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8713
This is against 3.4, because it is the first time that your commands will be registered as services in practice.