Skip to content

Reduce ambiguity of encore installation #8674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mahalay
Copy link
Contributor

@mahalay mahalay commented Nov 16, 2017

No description provided.

@weaverryan
Copy link
Member

This is great! I've just added one other change - to add yarn install after installing via Flex.

I'm actually not sure if having two commands inside a code-block:: terminal is legal... but I think it is :)

Status: Reviewed

@weaverryan
Copy link
Member

Yep, the multi-line terminal block is ok. This is ready!

@xabbuh
Copy link
Member

xabbuh commented Nov 23, 2017

Thank you @mahalay.

xabbuh added a commit that referenced this pull request Nov 23, 2017
…yan)

This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #8674).

Discussion
----------

Reduce ambiguity of encore installation

Commits
-------

514cdb9 Adding yarn install text
b852a98 Reduce ambiguity of encore installation
@xabbuh xabbuh closed this Nov 23, 2017
@mahalay
Copy link
Contributor Author

mahalay commented Nov 23, 2017

Thank you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants