Reworded the explanation about service tags #8651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
requested changes
Nov 16, 2017
service_container/tags.rst
Outdated
| Tags, then, are a way to tell Symfony or other third-party bundles that | ||
| your service should be registered or used in some special way by the bundle. | ||
| Services tagged with the ``twig.extension`` tag are collected during the | ||
| initialization of TwigBundle to enable them as Twig extensions. In this example, |
There was a problem hiding this comment.
How about?
... TwigBundle and added to Twig as extensions.
service_container/tags.rst
Outdated
| Services tagged with the ``twig.extension`` tag are collected during the | ||
| initialization of TwigBundle to enable them as Twig extensions. In this example, | ||
| that's why Symfony knows that the ``app.twig_extension`` service should be | ||
| registered as a Twig extension. |
There was a problem hiding this comment.
I'm not convinced this last sentence adds any value.
A total alternative, could be:
Other tags are used to integrate your services into other systems.
(actually, this could be the first sentence of the next paragraph)
service_container/tags.rst
Outdated
| Consider for example the :doc:`Twig extensions </templating/twig_extension>`: | ||
| they are PHP classes that must be added to the main Twig object before using | ||
| them. If you define those exensions as regular Symfony services, Twig will | ||
| ignore them and an exception will be thrown when using them in templates. |
There was a problem hiding this comment.
I actually like your second paragraph a lot... and I think we should only have it, and remove the first paragraph completely. wdyt?
|
Status: Needs Work |
|
Thanks for the review! I agree, let's remove anything that doesn't provide true value. |
|
Thanks Javier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.