Skip to content

Migrating "Business Logic" topics to Symfony Flex structure #8578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2017

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Nov 2, 2017

No description provided.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a separate PR, when we rethink the "best practices" we should reword this article to say that autowiring is a good practice and making services public to get them from the container is not a good practice.

@@ -10,48 +10,20 @@ your app that's not specific to the framework (e.g. routing and controllers).
Domain classes, Doctrine entities and regular PHP classes that are used as
services are good examples of business logic.

For most projects, you should store everything inside the AppBundle.
For most projects, you should store everything inside the ``src/`` directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

store everything -> store all your code ? Now almost everything is outside src/ (translations, templates, assets, etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@weaverryan
Copy link
Member

Another great one! As Javier said, we need to read the best practices for bigger changes (updated recommendations). But updating it at least to be accurate to the new structure first makes a lot of sense :)

@weaverryan weaverryan merged commit 6e0d89a into symfony:master Nov 5, 2017
weaverryan added a commit that referenced this pull request Nov 5, 2017
…ture (yceruto)

This PR was merged into the master branch.

Discussion
----------

Migrating "Business Logic" topics to Symfony Flex structure

Commits
-------

6e0d89a Migrating "Business Logic" topics to Symfony Flex structure
@yceruto yceruto deleted the business_logic branch November 5, 2017 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants