Grouped assets example #8574
Merged
Grouped assets example #8574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When absolute path is provided in getUrl(), base path is ignored.
|
Hey @takman1! If I understand it correctly, both |
|
Hello Ryan, |
|
Ah, of course! You're right, and this is an important point. But there are many other times in this article when we use @takman1 could you make those changes? |
|
Hi @weaverryan, |
How alsolute paths are handeled in Package and PathPackage.
xabbuh
approved these changes
Nov 8, 2017
|
This is great! Thank you @takman1! |
weaverryan
added a commit
that referenced
this pull request
Nov 10, 2017
This PR was squashed before being merged into the 3.3 branch (closes #8574). Discussion ---------- Grouped assets example Asset > PathPackage > Grouped assets section > example When absolute path is provided in getUrl(), base path is ignored. Commits ------- a29765d Asset Component and absolute paths 95a79fd Grouped assets example
takman1
added a commit
to takman1/symfony-docs
that referenced
this pull request
Nov 10, 2017
How to reproduce :
- Application has a base url (/some-base-url)
- Using "PathPackage"
- Using RequestStackContext (3rd parameter),
- getUrl of asset with absolute path.
Result :
Both "base url" of application and "base path" of PathPackage are ignored.
Example :
Application base url : /some-prefix
$package = new PathPackage('/static/', new StaticVersionStrategy('v1.2'), new RequestStackContext($requestStack));
echo $package->getUrl("/img.png"); // /img.png?v1.2
Check merged PR symfony#8574.
NB : Maybe there a conception problem in Asset component. I my opinion only "base path" should be ignored but "base url" should always be used to prefix the generated asset path.
This was referenced Nov 10, 2017
javiereguiluz
added a commit
that referenced
this pull request
Jan 12, 2018
This PR was merged into the 3.3 branch.
Discussion
----------
Path package in context aware
How to reproduce :
- Application has a base url (/some-base-url)
- Using "PathPackage"
- Using RequestStackContext (3rd parameter),
- getUrl of asset with absolute path.
Result :
Both "base url" of application and "base path" of PathPackage are ignored.
Example :
Application base url : /some-prefix
$package = new PathPackage('/static/', new StaticVersionStrategy('v1.2'), new RequestStackContext($requestStack));
echo $package->getUrl("/img.png"); // /img.png?v1.2
Check merged PR #8574.
NB : Maybe there a conception problem in Asset component. I my opinion only "base path" should be ignored but "base url" should always be used to prefix the generated asset path.
Commits
-------
0dbb635 Path package in context aware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asset > PathPackage > Grouped assets section > example
When absolute path is provided in getUrl(), base path is ignored.