Skip to content

Update YAML service #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update YAML service #8551

wants to merge 1 commit into from

Conversation

matt9mg
Copy link
Contributor

@matt9mg matt9mg commented Oct 26, 2017

Use the new service container configuration in the yaml example

@matt9mg
Update YAML service
82dbad2 
Use the new service container configuration in the yaml example
javiereguiluz
javiereguiluz approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Note to mergers: it should be merged on 3.3 branch. Thanks!

@xabbuh xabbuh added this to the 3.3 milestone Oct 27, 2017
@xabbuh
Copy link
Member

xabbuh commented Oct 27, 2017

Thank you @matt9mg.

xabbuh added a commit that referenced this pull request Oct 27, 2017
@xabbuh
minor #8551 Update YAML service (matt9mg)
61b38a4 
This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #8551).

Discussion
----------

Update YAML service

Use the new service container configuration in the yaml example

Commits
-------

461c53a Update YAML service
@xabbuh xabbuh closed this Oct 27, 2017
@matt9mg
Copy link
Contributor Author

matt9mg commented Oct 27, 2017

@xabbuh anytime 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@matt9mg @xabbuh @javiereguiluz @carsonbot