Improved the first example of the Guard authenticator #8519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we maybe also take #8611 into account here? |
|
Yes, this is much better - great change! I'll keep the other issue for later, it seems somewhat related, but more complex |
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2017
…ereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Improved the first example of the Guard authenticator I don't like the changes I made to this example in #8497. I consider that the new version of the example makes more sense and it's more correct. Commits ------- ad84f23 Improved the first example of the Guard authenticator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the changes I made to this example in #8497. I consider that the new version of the example makes more sense and it's more correct.