[Dependency Injection ] Fix _instanceof configuration section. #8514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Oct 13, 2017
service_container/3.3-di-changes.rst
Outdated
| class: AppBundle\Domain\LoaderInterface | ||
| public: true | ||
| tags: ['app.domain_loader'] | ||
| AppBundle\Domain\LoaderInterface |
There was a problem hiding this comment.
@yceruto nice catch, fixed
javiereguiluz
approved these changes
Oct 17, 2017
|
Good catch, thanks @mimol91. |
xabbuh
added a commit
that referenced
this pull request
Oct 27, 2017
…tion. (mimol91)
This PR was merged into the 3.3 branch.
Discussion
----------
[Dependency Injection ] Fix _instanceof configuration section.
It seems that previous configuration
```yml
_instanceof:
class: AppBundle\Domain\LoaderInterface
public: true
tags: ['app.domain_loader']
```
throws an error: `Type definition "class" must be a non-empty array within "_instanceof" in `. Moreover, it will not be possible to configure multiple 'elements'
After this changes it works as expected.
Commits
-------
029d11e [Dependency Injection ] Fix _instanceof configuration section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that previous configuration
throws an error:
Type definition "class" must be a non-empty array within "_instanceof" in. Moreover, it will not be possible to configure multiple 'elements'After this changes it works as expected.