Skip to content

[Form] Add documentation for new tel and color types #8488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2017
Merged

[Form] Add documentation for new tel and color types #8488

merged 3 commits into from
Oct 13, 2017

Conversation

apetitpa
Copy link
Contributor

@apetitpa apetitpa commented Oct 7, 2017

@apetitpa apetitpa changed the title Add documentation for new tel and color types [Form] Add documentation for new tel and color types Oct 7, 2017
@xabbuh xabbuh added this to the 3.4 milestone Oct 7, 2017
@javiereguiluz
Copy link
Member

After reading https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color I wonder if the ColorType of Symfony follows the HTML5 spec regarding this:

The value of a element of type "color" is always a DOMString which contains a 7-character string specifying an RGB color in lower case hexadecimal notation. The value is never in any other form, and is never empty.

Setting the value to anything that isn't a valid, fully-opaque, RGB color in hexadecimal notation will result in the value being set to "#000000". In particular, you can't use CSS's standardized color names, or any CSS functions, to set the value.

@xabbuh
Copy link
Member

xabbuh commented Oct 13, 2017

Thank you @apetitpa.

@xabbuh xabbuh merged commit a0deed8 into symfony:3.4 Oct 13, 2017
xabbuh added a commit that referenced this pull request Oct 13, 2017
…petitpa, javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Add documentation for new tel and color types

https://symfony.com/blog/new-in-symfony-3-4-form-improvements#new-html5-types

Commits
-------

a0deed8 Explain the new ColorType a bit more
58d8aa3 Explain the new TelType a bit more
655a94b add doc for new tel and color types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants