-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fixed the default value of framework.form.enabled #8468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
Whether to enable the form services or not in the service container. If | ||
you don't use forms, setting this to ``false`` may increase your application's | ||
performance because less services will be loaded into the container. | ||
|
||
The default value is ``true`` when the project uses ``symfony/symfony`` as a | ||
dependency. Otherwise, it defaults to ``false``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. The default is still disabled. The only case where it is automatically enabled is when you're using symfony/flex
and symfony/form
is required as well.
This also applies to assets, validation, translation, serialization and csrf. Can we add the note there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, issue updated accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. So I think explaining the logic behind the default value is too complex and doesn't add much value. A more useful thing is to run debug:config framework
. I think we should mention this command at the top of each reference, and remove the default
value in cases where there is not a simple answer.
Closed in favor of #8979. |
…k config (javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- Fixed the default values for "enabled" option in framework config This takes over #8468 and it's made on 4.0 branch because this is our first "Flex only" branch in docs. Commits ------- 1ff35b2 Fixed the default values for "enabled" option in framework config
This fixes #8412.