Skip to content

Property class is required #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Property class is required #8426

wants to merge 2 commits into from

Conversation

alexpts
Copy link
Contributor

@alexpts alexpts commented Sep 26, 2017

Without property class throw exception:
Uncaught Symfony\Component\DependencyInjection\Exception\RuntimeException: Please add the class to service "$name" even if it is constructed by a factory since we might need to add method calls based on compile-time checks.

Without property class throw exception:
`Uncaught Symfony\Component\DependencyInjection\Exception\RuntimeException: Please add the class to service "$name" even if it is constructed by a factory since we might need to add method calls based on compile-time checks.`
@xabbuh
Copy link
Member

xabbuh commented Sep 27, 2017

Can you update the other examples on the same page too?

@alexpts
Copy link
Contributor Author

alexpts commented Sep 27, 2017

OK, I will test that name service as className not work too and update other examples for yaml

@xabbuh
Copy link
Member

xabbuh commented Sep 27, 2017

Sorry, you are right. I missed that this PR was for the 3.3 branch. It's all good. :)

@xabbuh xabbuh added this to the 3.3 milestone Sep 27, 2017
@alexpts
Copy link
Contributor Author

alexpts commented Sep 27, 2017

Do You need anything else from me?

@xabbuh
Copy link
Member

xabbuh commented Sep 27, 2017

It's fine it is. :) When we'll do the next round of merges, this one will be a part of it. :)

@alexpts
Copy link
Contributor Author

alexpts commented Sep 27, 2017

Ok, Thank you

@wouterj
Copy link
Member

wouterj commented Sep 30, 2017

As promised, it's now merged in. Thanks for testing & fixing the documentation Alex!

wouterj added a commit that referenced this pull request Sep 30, 2017
This PR was squashed before being merged into the 3.3 branch (closes #8426).

Discussion
----------

Property class is required

Without property `class` throw exception:
`Uncaught Symfony\Component\DependencyInjection\Exception\RuntimeException: Please add the class to service "$name" even if it is constructed by a factory since we might need to add method calls based on compile-time checks.`

Commits
-------

f8f0e30 Property class is required
@wouterj wouterj closed this Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants