Skip to content

Document Memcached cache adapter added in Symfony 3.3 #8407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

aik099
Copy link

@aik099 aik099 commented Sep 18, 2017

Adds documentation for Memcached cache adapter.

Related blog post: https://symfony.com/blog/new-in-symfony-3-3-memcached-cache-adapter

Closes #7828

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've left one minor comment, but that can be fixed during the merge

..........................

.. versionadded:: 3.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty line should be removed (versionadded is kinda a strange directive that requires this...)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aik099
Copy link
Author

aik099 commented Sep 19, 2017

I wonder why the Platform.sh build was triggered on my other PR, but not on this one.

@wouterj
Copy link
Member

wouterj commented Sep 19, 2017

It is triggered (at least now) if you collapse the status item you can see it.

@xabbuh xabbuh added this to the 3.3 milestone Sep 22, 2017
@xabbuh
Copy link
Member

xabbuh commented Sep 22, 2017

Thank you @aik099.

@xabbuh xabbuh merged commit 203e43f into symfony:3.3 Sep 22, 2017
xabbuh added a commit that referenced this pull request Sep 22, 2017
…k099)

This PR was merged into the 3.3 branch.

Discussion
----------

Document Memcached cache adapter added in Symfony 3.3

Adds documentation for Memcached cache adapter.

Related blog post: https://symfony.com/blog/new-in-symfony-3-3-memcached-cache-adapter

Closes #7828

Commits
-------

203e43f Document Memcached cache adapter added in Symfony 3.3
@aik099 aik099 deleted the fix_7828 branch September 24, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants