-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Improve description about "framework.ide" config option #8405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve description about "framework.ide" config option #8405
Conversation
symfony/symfony#24129 might need clarification as well 👍 |
@ro0NL , I've left a note in that issue. Hope that helps. |
I think the part as of Thus instead of
I'd say
Thus escaped. |
@ro0NL , is this related to changes I've made in this PR? If so, the I don't understand what you want me to change. If you have push access to this repo, then you already can add more commits to my PR branch. |
Not really related. I thought it was an issue (not a PR) so i quickly comment as well :) related to the same subject though. Ill have a look in different PR soonish otherwise. Issue solved, feel free to ignore :) |
👍 Seems correct to me. Thanks for your detailed PR description & patch! status: reviewed |
Thank you @aik099. |
…aik099) This PR was submitted for the 3.2 branch but it was merged into the 3.3 branch instead (closes #8405). Discussion ---------- Improve description about "framework.ide" config option According to code in https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L179 when both `xdebug.file_link_format` (in `php.ini`) and `framework.ide` (in `app/config/config.yml`) are defined, then `xdebug.file_link_format` wins, but documentetion says the opposite. P.S. * PR is targeting the oldest supported documentation branch, where fixed text fragment is present. * It should be merged to `3.3` and `3.4` branches as well. * The documentation is changed and not mentioned code, because changing code would introduce a BC break. Commits ------- 432d456 Improve description about "framework.ide" config option
According to code in https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L179 when both
xdebug.file_link_format
(inphp.ini
) andframework.ide
(inapp/config/config.yml
) are defined, thenxdebug.file_link_format
wins, but documentetion says the opposite.P.S.
3.3
and3.4
branches as well.